Integrate Schema Registry with ducktape load tests #2027
+247
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
This comment has been minimized.
This comment has been minimized.
MSeal
reviewed
Aug 20, 2025
| self.logger.info("Verifying connection to external Kafka at localhost:9092") | ||
|
|
||
| if not self.kafka.verify_connection(): | ||
| raise Exception("Cannot connect to Kafka at localhost:9092. " |
There was a problem hiding this comment.
As SonarQube suggests never throw an Exception or BaseException. I'd maybe raise a ConnectionError here.
This comment has been minimized.
This comment has been minimized.
fangnx
changed the title
Analysis Details4 Issues
Coverage and Duplications
Project ID: confluent-kafka-python |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add basic ducktape test cases for producer w/ schema registry integrated, covering 3 supported serialization formats.
As a follow-up item, we can explore testing producing with with different sizes of messages to be serialized.
Checklist
References
JIRA: https://confluentinc.atlassian.net/browse/DGS-21924
Test & Review
Open questions / Follow-ups