FIxed race condition on deleting old adjustment records #3901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To get this potential fix early and test out the PR, change your "require": {
"craftcms/commerce": "dev-feature/pt-2407-fix-adjustment-id-race-condition as 4.8.1.2",
"...": "..."
}Then run We will update this ticket once the release is out. |
|
@lukeholder any news on this? |
|
@lukeholder I want to test this on Craft 5, can you make an updated branch for that? |
|
Now seeing a lot of these errors so I can test it properly if you want |
|
@boboldehampsink Yes please, testing this would be useful. Updated to 5.x base branch. |
lukeholder
added a commit
that referenced
this pull request
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No need to delete the Record if we already drop the rows directly in the database.
Related issues
#3283