Skip to content

Add PHP 8.5 support #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Add PHP 8.5 support #819

wants to merge 19 commits into from

Conversation

crazywhalecc
Copy link
Owner

@crazywhalecc crazywhalecc commented Jul 15, 2025

What does this PR do?

Support PHP 8.5 alpha.

TODO

Buggy Extension builds

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php or *.json, run them locally to ensure your changes are valid:
    • PHP_CS_FIXER_IGNORE_ENV=1 composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:sort-config
  • If it's an extension or dependency update, please ensure the following:
    • Add your test combination to src/globals/test-extensions.php.
    • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

@crazywhalecc crazywhalecc self-assigned this Jul 15, 2025
@crazywhalecc crazywhalecc added kind/php-and-sapi Issues related to php source and SAPI mixed PR This PR contains multiple updates labels Jul 15, 2025
@crazywhalecc crazywhalecc marked this pull request as draft July 15, 2025 13:19
@henderkes
Copy link
Collaborator

Hahaha, I have been working on this, too.

@henderkes
Copy link
Collaborator

We should also put a watch on php/php-src#18660 because it might land in 8.5.

@henderkes
Copy link
Collaborator

It was merged, opcache is always statically compiled into php 8.5.

@crazywhalecc
Copy link
Owner Author

Looks like we have to wait alpha3 or test master branch directly.

@crazywhalecc
Copy link
Owner Author

We should also put a watch on php/php-src#18660 because it might land in 8.5.

Looks like we don't need to patch opcache for PHP 8.5 at all. We only need to add version check and just ignore opcache extension like json, but the phpmicro project would have to create an empty patch file to avoid backward conflicts.

Copy link
Owner Author

@crazywhalecc crazywhalecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/php-and-sapi Issues related to php source and SAPI mixed PR This PR contains multiple updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants