-
-
Notifications
You must be signed in to change notification settings - Fork 297
Add PHP 8.5 support #819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add PHP 8.5 support #819
Conversation
Hahaha, I have been working on this, too. |
We should also put a watch on php/php-src#18660 because it might land in 8.5. |
# Conflicts: # src/globals/test-extensions.php
It was merged, opcache is always statically compiled into php 8.5. |
Looks like we have to wait alpha3 or test master branch directly. |
Looks like we don't need to patch opcache for PHP 8.5 at all. We only need to add version check and just ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change
What does this PR do?
Support PHP 8.5 alpha.
TODO
Buggy Extension builds
Checklist before merging
*.php
or*.json
, run them locally to ensure your changes are valid:PHP_CS_FIXER_IGNORE_ENV=1 composer cs-fix
composer analyse
composer test
bin/spc dev:sort-config
src/globals/test-extensions.php
.extension test
ortest extensions
to trigger full test suite.