Skip to content

Conversation

diznq
Copy link
Member

@diznq diznq commented Aug 2, 2025

Add parallel logging that can be used during crash log to retrieve logs of all verbosities in past log_paralog seconds.

Copy link
Member

@ccomrade ccomrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

@@ -8,6 +8,7 @@
#include <psapi.h>

#include "CrashLogger.h"
#include "CrySystem/Logger.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Library stuff shouldn't depend on the engine to avoid circular dependencies. What about adding one more crash logger callback? Something like:

using ExtraInfoProvider = void (*)(std::FILE* file);

And passing it to CrashLogger::Enable in Launcher:

CrashLogger::Enable(&ProvideLogFile, &CryMemoryManager::ProvideHeapInfo, banner);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While that's true, however you cannot have a circular dependency from .cpp file to .h file, only from .h file to another .h file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, yes, but i meant it as a dependency between components. We probably don't want to end up like Mod SDK, where so many things are included everywhere and changing one header usually means recompiling a lot of stuff.

@diznq diznq closed this Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants