feat(backport): add support for eth_getBlockReceipts #1823
Conversation
* add support eth_getBlockReceipts * update go mod * update gomod2nix.toml * add test for blockReceipts * python lint
thomas-nguy
requested review from
JayT106 and
calvinaco
and removed request for
a team
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
WalkthroughThis update introduces version 1.4.8, highlighted by support for the Changes
Sequence Diagram(s)sequenceDiagram
participant TestSuite
participant JSONRPC_Server
participant Blockchain
TestSuite->>JSONRPC_Server: eth_getBlockReceipts(blockNumber)
JSONRPC_Server->>Blockchain: Fetch all receipts for blockNumber
Blockchain-->>JSONRPC_Server: Return receipts list
JSONRPC_Server-->>TestSuite: Return receipts list
TestSuite->>TestSuite: Compare block receipts to individual tx receipts
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🪛 markdownlint-cli2 (0.17.2)CHANGELOG.md9-9: Emphasis used instead of a heading (MD036, no-emphasis-as-heading) ⏰ Context from checks skipped due to timeout of 90000ms (17)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1823 +/- ##
===========================================
+ Coverage 16.87% 35.57% +18.70%
===========================================
Files 72 127 +55
Lines 6163 11963 +5800
===========================================
+ Hits 1040 4256 +3216
- Misses 5000 7279 +2279
- Partials 123 428 +305 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (4)
docs/architecture/adr-001.md (1)
68-68: Prefer immutable links overmainto keep the ADR reproduciblePointing to a moving
mainbranch means the referenced document can silently change and break historic context.
Use a permalink (commit SHA / tag) or a versioned release for long-lived ADRs.-* in-place store migrations: https://github.com/cosmos/cosmos-sdk/blob/main/docs/architecture/adr-041-in-place-store-migrations.md +* in-place store migrations: https://github.com/cosmos/cosmos-sdk/blob/<commit-sha>/docs/architecture/adr-041-in-place-store-migrations.mdCHANGELOG.md (1)
9-15: Use a heading for the release date to satisfy markdown-lint
*Jun 20, 2025*is flagged by MD036 (“emphasis used instead of a heading”).
Convert it to a level-3 heading to keep tooling quiet and stay consistent with other entries.-*Jun 20, 2025* +### Jun 20 2025docs/api/json-rpc/events.md (1)
77-78: Minor wording / punctuation nit.To improve readability, consider inserting a comma after “Then”:
-Then you can check if the state changes with the ... +Then, you can check if the state changes with the ...integration_tests/test_basic.py (1)
550-550: Remove unnecessary blank line.This blank line appears to serve no purpose and could be removed for cleaner code.
-
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (10)
CHANGELOG.md(1 hunks)default.nix(1 hunks)docs/api/json-rpc/endpoints.md(2 hunks)docs/api/json-rpc/events.md(2 hunks)docs/api/json-rpc/server.md(1 hunks)docs/architecture/adr-001.md(1 hunks)docs/architecture/adr-008.md(0 hunks)go.mod(1 hunks)gomod2nix.toml(1 hunks)integration_tests/test_basic.py(2 hunks)
💤 Files with no reviewable changes (1)
- docs/architecture/adr-008.md
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/architecture/adr-001.md
68-68: Bare URL used
null
(MD034, no-bare-urls)
CHANGELOG.md
9-9: Emphasis used instead of a heading
null
(MD036, no-emphasis-as-heading)
docs/api/json-rpc/endpoints.md
41-41: Link fragments should be valid
null
(MD051, link-fragments)
🪛 LanguageTool
docs/api/json-rpc/events.md
[uncategorized] ~77-~77: A punctuation mark might be missing here.
Context: ...can check if the state changes with the [eth_getFilterChanges](https://ethereum...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
⏰ Context from checks skipped due to timeout of 90000ms (16)
- GitHub Check: unittest
- GitHub Check: integration_tests (slow)
- GitHub Check: build (macos-14)
- GitHub Check: build (macos-latest)
- GitHub Check: integration_tests (gas)
- GitHub Check: build (ubuntu-latest)
- GitHub Check: integration_tests (upgrade)
- GitHub Check: integration_tests (ibc_timeout)
- GitHub Check: integration_tests (ibc_rly_evm)
- GitHub Check: integration_tests (gov)
- GitHub Check: integration_tests (ibc)
- GitHub Check: integration_tests (ica)
- GitHub Check: integration_tests (ibc_update_client)
- GitHub Check: integration_tests (ibc_rly_gas)
- GitHub Check: integration_tests (unmarked)
- GitHub Check: Run golangci-lint
🔇 Additional comments (6)
go.mod (1)
275-275: Rungo mod tidyafter bumpingethermintThe
replacenow pinsgithub.com/crypto-org-chain/ethermintto823fc683e6f0, but the corresponding
require github.com/evmos/ethermint …stanza still carries the zero timestamp placeholder.
go mod tidywill normalise that line and ensurego.sumis updated, avoiding future CI drift.default.nix (1)
14-14: Version bump looks good
version = "v1.4.8";matches the new changelog entry and tagging convention. No further action required.docs/api/json-rpc/server.md (1)
11-11: 👍 Updated JSON-RPC reference URLThe new path (
docs/reference/json-rpc-api) is correct and resolves. Good catch.docs/api/json-rpc/endpoints.md (1)
11-11: URL update looks good.The new canonical path for the Execution-APIs site is correct and renders properly.
docs/api/json-rpc/events.md (1)
63-66: URL base-path change acknowledged.All three filter-related links now use the new Execution-APIs location – confirmed to load correctly.
gomod2nix.toml (1)
266-268: ```shell
#!/bin/bashVerify that go.sum includes the bumped pseudo-version
grep -n "v0.6.1-0.20250618065241-823fc683e6f0" go.sum || true
</details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
|
seems that the markdown link check failure is a false positive |
|
LGTM, perhaps can mention it's a backport PR in the PR description. |
thomas-nguy
changed the title
2d8a5be
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit
New Features
eth_getBlockReceipts.Documentation
eth_getBlockReceiptsmethod and revised several external reference URLs for improved accuracy.Chores