make pvc count in group configurable

[Nikhil-Ladha]

Added support for configuring the pvc count in a group. The min and max values are 1 and 100, anything less and more than that would result in an error in the controller manager.
Also, added necessary unit tests to validate the values in the config.

Fixes: #787

[nixpanic]

Looks good, but 100 PVCs in a group sounds like really a lot. Are there any use-cases known that make groups, and do we know how large such a group is common?

Please update the documentation in docs/csi-addons-config.md too.

[Nikhil-Ladha]

Looks good, but 100 PVCs in a group sounds like really a lot. Are there any use-cases known that make groups, and do we know how large such a group is common?

I am not aware of a direct use case as such were such a large number would be required. This is the upper limit that we would allow, and that is the max count that has been tested by ceph team too, some DR use cases would require somewhere around 60-80 at max. Hence, setting the limit and default value to 100, so that it the users wont' really have to tweak the value until and unless there is some exception.

Please update the documentation in docs/csi-addons-config.md too.

Done.

[nixpanic]

This is the upper limit that we would allow, and that is the max count that has been tested by ceph team too, some DR use cases would require somewhere around 60-80 at max.

would allow in case of Ceph, I assume? If Ceph is the reference for the value, it would be good to mention that in a comment where the default is set in the code.

That is the only thing that I'd like to see improved, looks good otherwise.

[Nikhil-Ladha]

This is the upper limit that we would allow, and that is the max count that has been tested by ceph team too, some DR use cases would require somewhere around 60-80 at max.

would allow in case of Ceph, I assume? If Ceph is the reference for the value, it would be good to mention that in a comment where the default is set in the code.

That is the only thing that I'd like to see improved, looks good otherwise.

Ack, a note like the following in the docs/csi-addons-config.yaml should be fine I think?

NOTE: `max-group-pvcs` default value is set based on ceph's support/testing. User can tweak this value based on the supported count for their storage vendor.

[Nikhil-Ladha]

Added the note, please take a look now.
Thanks :)

[Rakshith-R]

Thanks