drone flight. Steps towards #204 and #348 #427
+5,469
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moorepants
reviewed
May 31, 2025
| # Plot the objective function as a function of optimizer iteration. | ||
| _ = prob.plot_objective_value() | ||
|
|
||
| np.savetxt(fname, solution, fmt='%.12f') |
There was a problem hiding this comment.
This breaks the formatting of the rst text sections.
There was a problem hiding this comment.
Should probably be deleted. Strang, it worked with me otherwise I would not have pushed it...
|
It built fine with me. |
|
When you move the comments into these if statements or loops, you generally break the RST formatting. This is done on several examples you have edited. The text in the examples should (almost) always be rendered as HTML via RST text, not as Python comments. |
|
Thanks, I did not know this. Will remove these comments, not so necessary anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my PC running time reduced to around 12 sec from around 32 sec