refactor: explicit null types for php 8.4 #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielme85
approved these changes
Nov 25, 2024
|
Thank you @joostdebruijn, for all your help and being proactive! Feel free to merge whenever, you should have the honors :) or ill merge it EOD. I'll update my test/dev environments to php 8.4 and do some more practical testing this week/next weekend. |
|
Thanks! As I don't have merge rights on this repo, you should do it. :) |
Ah that's right, 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.4 prohibits implicit null types and will throw a deprecation warning for it. This PR fixes that.