Better avoid and handle AWS API throttling #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-175
to
-189
| while True: | ||
| try: | ||
| [self.task] = ( | ||
| await ecs.describe_tasks( | ||
| cluster=self.cluster_arn, tasks=[self.task_arn] | ||
| ) | ||
| )["tasks"] | ||
| except ClientError as e: | ||
| if e.response["Error"]["Code"] == "ThrottlingException": | ||
| wait_duration = min(wait_duration * 2, 20) | ||
| else: | ||
| raise | ||
| else: | ||
| break | ||
| await asyncio.sleep(wait_duration) |
There was a problem hiding this comment.
Am I right in understanding that we are removing our retry logic here and leveraging the built-in retries in aiobotocore?
There was a problem hiding this comment.
Correct. Sorry, I stuck this draft PR up as a placeholder and hadn't yet added a detailed description to describe this. Done now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current ECS implementation has a couple issues regarding AWS API throttling that are especially problematic when starting a large cluster (over ~100 workers)
Workermakes its own call toecs.list_account_settingsto determine iftaskLongArnFormatis enabled rather than doing this just once at theECSClusterlevel. This PR optimized some of the easy cases like this. The most notable one that's NOT addressed isecs.describe_tasksthat each worker polls as it's waiting to come up.References: