-
Notifications
You must be signed in to change notification settings - Fork 795
feat(query): add rule_grouping_sets_to_union #18413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sundy-li
merged 92 commits into
databendlabs:main
from
sundy-li:rule_grouping_sets_to_union
Jul 28, 2025
Merged
feat(query): add rule_grouping_sets_to_union #18413
sundy-li
merged 92 commits into
databendlabs:main
from
sundy-li:rule_grouping_sets_to_union
Jul 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/query/service/src/sessions/query_ctx.rs
Co-authored-by: Winter Zhang <[email protected]>
…cte.rs Co-authored-by: Winter Zhang <[email protected]>
…eanup_unused_cte.rs Co-authored-by: Winter Zhang <[email protected]>
Is function |
sundy-li
commented
Jul 28, 2025
src/query/sql/src/planner/optimizer/optimizers/rule/agg_rules/rule_grouping_sets_to_union.rs
Show resolved
Hide resolved
sundy-li
commented
Jul 28, 2025
tests/sqllogictests/suites/duckdb/sql/aggregate/group/group_by_grouping_sets_union_all.test
Show resolved
Hide resolved
SkyFan2002
approved these changes
Jul 28, 2025
zhang2014
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci-cloud
Build docker image for cloud test
pr-feature
this PR introduces a new feature to the codebase
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
feat(query): add rule_grouping_sets_to_union
add a new setting
grouping_sets_to_union
which apply this rule (default disabled)Split
Grouping Sets
intoUnion All
ofGroup by
Eg:
INTO:
And with CTE integration after pr #18226
performance 2X:
Tests
Type of change
This change is