Skip to content

feat(metactl): add comprehensive test suite for all subcommands #18431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2025

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Jul 27, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

feat(metactl): add comprehensive test suite for all subcommands
  • Add get and trigger-snapshot subcommands to metactl CLI
  • Implement complete test coverage for all metactl subcommands:
    status, upsert, get, watch, trigger-snapshot, export-from-grpc,
    export-from-raft-dir, import, transfer-leader
  • Extract shared utilities into metactl_utils.py and utils.py
  • Add unified test runner (test_all_subcommands.py) for CI integration
  • Add comprehensive documentation (README_SUBCOMMAND_TESTS.md)

Tests include precise verification of command outputs, error handling,
and end-to-end functionality validation with proper cleanup.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Other

Related Issues


This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jul 27, 2025
@drmingdrmer drmingdrmer force-pushed the 362-2 branch 2 times, most recently from 13a53f6 to 2a4de50 Compare July 27, 2025 05:38
- Add `get` and `trigger-snapshot` subcommands to metactl CLI
- Implement complete test coverage for all metactl subcommands:
  status, upsert, get, watch, trigger-snapshot, export-from-grpc,
  export-from-raft-dir, import, transfer-leader
- Extract shared utilities into metactl_utils.py and utils.py
- Add unified test runner (test_all_subcommands.py) for CI integration
- Add comprehensive documentation (README_SUBCOMMAND_TESTS.md)

Tests include precise verification of command outputs, error handling,
and end-to-end functionality validation with proper cleanup.
@drmingdrmer drmingdrmer marked this pull request as ready for review July 27, 2025 11:44
@drmingdrmer drmingdrmer merged commit 0f00f38 into databendlabs:main Jul 27, 2025
89 of 90 checks passed
@drmingdrmer drmingdrmer deleted the 362-2 branch July 27, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant