Make transpile config flexible #1488
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esiliency * no-default-transpiler-install: fix typo formatting only install rct and morpheus when installing 'transpiler' module only install rct and morpheus when installing 'transpiler' module
…g-flexible * improve-installer-resiliency: formatting fix typo improve resiliency improve resiliency formatting only install rct and morpheus when installing 'transpiler' module only install rct and morpheus when installing 'transpiler' module
…exible * fix-missing-dependencies: remove duplicate update dependencies fix missing dependency
…-options * improve-installer-resiliency: formatting fix typo improve resiliency improve resiliency # Conflicts: # src/databricks/labs/remorph/install.py
…g-flexible * configure-lsp-custom-options: formatting and failing tests pass transpiler options add init time and check reception update rct config add tests and fix issues fix typo reads config options
|
❌ 13/14 passed, 1 failed, 1 skipped, 11s total ❌ test_stores_and_fetches_config: databricks.labs.blueprint.installation.SerdeError: transpiler_options.(as dict[str, any]).b: unknown: c (1.722s)Running from acceptance #313 |
…g-flexible * improve-installer-resiliency: formatting improve resiliency
…ible * improve-LSP-resiliency: increase timeout when waiting for transpile capability registration improve lsp server isolation
* fix-labs.yml: use null instead of None in morpheus installer
asnare
reviewed
Apr 3, 2025
| input_source: str | None = None | ||
| output_folder: str | None = None | ||
| error_file_path: str | None = None | ||
| sdk_config: dict[str, str] | None = None | ||
| skip_validation: bool = False | ||
| catalog_name: str = "remorph" | ||
| schema_name: str = "transpiler" | ||
| transpiler_options: dict[str, Any] | None = None |
There was a problem hiding this comment.
What are the types of the values in this dictionary supposed to be?
There was a problem hiding this comment.
Any type. That's data provided by the transpiler config, that we don't control. It's any valid JSON.
There was a problem hiding this comment.
JSONValue: typing.TypeAlias = None | bool | int | float | str | list["JSONValue"] | dict[str, "JSONValue"]* main: Improve lsp resiliency (#1491) Hot Fix for Dashboard Names (#1476) Improve installer resiliency (#1484) Patch Contributing Document (#1506) Introduce Documentation for Remorph (#1460) Fix missing dependencies (#1485) Installation Improvements (#1495) Update transpilers.md (#1486) Drop proxy commands (#1493) Fix labs.yml (#1490) Configure lsp custom options (#1487) Add support for DBT (#1456) # Conflicts: # pyproject.toml # src/databricks/labs/remorph/config.py # src/databricks/labs/remorph/install.py # src/databricks/labs/remorph/transpiler/execute.py # tests/unit/test_install.py
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current code requires various transpile config fields at
installtime, but requires them as parameters when runningtranspile.This PR fixes the discrepancy by:
installtimetranspiletimetranspiletimeBuilds on top of the following PRs:
#1491
#1490
#1487
#1485
#1484
#1480
#1472
#1456
Also requires databrickslabs/blueprint#189