Skip to content

DO NOT MERGE circuit breaker #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DO NOT MERGE circuit breaker #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions caddy-modules/devxupstreamer/devxupstreamer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"net/http"
"strconv"
"strings"
"sync/atomic"

"github.com/caddyserver/caddy/v2"
"github.com/caddyserver/caddy/v2/caddyconfig/caddyfile"
Expand All @@ -16,9 +17,10 @@ import (
)

type DevxUpstreamsModule struct {
hub *sentry.Hub
logger *zap.Logger
listener *storelistener.Listener
hub *sentry.Hub
logger *zap.Logger
listener *storelistener.Listener
failureCount *atomic.Int64
}

func init() {
Expand All @@ -29,15 +31,18 @@ func init() {
// CaddyModule returns the Caddy module information.
func (DevxUpstreamsModule) CaddyModule() caddy.ModuleInfo {
return caddy.ModuleInfo{
ID: "http.reverse_proxy.upstreams.devx",
New: func() caddy.Module { return new(DevxUpstreamsModule) },
ID: "http.reverse_proxy.upstreams.devx",
New: func() caddy.Module {
return new(DevxUpstreamsModule)
},
}
}

func (d *DevxUpstreamsModule) Provision(ctx caddy.Context) error {
// Get logger for the context of this caddy module instance
d.logger = ctx.Logger(d)
d.logger.Info("Provision called")
d.failureCount = &atomic.Int64{}
return nil
}

Expand All @@ -60,6 +65,11 @@ func (d *DevxUpstreamsModule) GetUpstreams(r *http.Request) ([]*reverseproxy.Ups

// If no upstream was selected log and return error
if data.UpstreamHost == "" {
if n := d.failureCount.Add(1); n > 10 {
// FIXME: Shut down and restart listeners if we have several issues in a short period
d.failureCount.Store(0)
}

err := upstreamMissingError(data)
d.logger.Warn(
"Failed to get upstream",
Expand Down