Skip to content

refactor: adapted native elements syntax from documentation #4096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

refactor: adapted native elements syntax from documentation #4096

wants to merge 4 commits into from

Conversation

mfranzke
Copy link
Collaborator

Proposed changes

documentation: https://design-system.deutschebahn.com/core-web/version/v2.0.2/components/data-display/tag/overview#

Resolves #4095

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Apr 22, 2025
@mfranzke mfranzke self-assigned this Apr 22, 2025
@mfranzke mfranzke requested a review from nmerget as a code owner April 22, 2025 13:05
@mfranzke mfranzke linked an issue Apr 22, 2025 that may be closed by this pull request
tag: align showcase and documentation #4095
Open
@github-actions github-actions bot added 📕documentation Improvements or additions to documentation 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases labels Apr 22, 2025
@mfranzke mfranzke moved this to 👀 In review in UX Engineering Team Backlog Apr 22, 2025
@mfranzke mfranzke removed their assignment Apr 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/4095-tag-align-showcase-and-documentation

@mfranzke mfranzke enabled auto-merge (squash) April 23, 2025 02:40
@nmerget
Copy link
Collaborator

nmerget commented Apr 23, 2025

Both variants should work the same way. Based on the changes of the snapshots, we need to fix the distance between the check icon. Furthermore, we should test both variants at least for the component tests

@mfranzke
Copy link
Collaborator Author

Both variants should work the same way. Based on the changes of the snapshots, we need to fix the distance between the check icon. Furthermore, we should test both variants at least for the component tests

#discuss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget Awaiting requested review from nmerget nmerget is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🏘components Changes inside components folder 📕documentation Improvements or additions to documentation 🍄🆙improvement New feature or request 📺showcases Changes to 1-n showcases
Projects
UX Engineering Team Backlog
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tag: align showcase and documentation
2 participants
@mfranzke @nmerget