Skip to content

refactor: call transformError when error is thrown outside of actions #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: call transformError when error is thrown outside of actions #611

wants to merge 1 commit into from

Conversation

lionelhorn
Copy link
Contributor

Summary of changes

  • Previously transformError was not called when an error occured in kernel.authenticate() for instance
  • Enable better sanitization of errors

Relinquishment of Rights

Please mark following checkbox to confirm that you relinquish all rights of your changes:

  • I waive and relinquish all rights regarding this changes (including code, text, and images) to Deepkit UG (limited), Germany. This changes (including code, text, and images) are under MIT license without name attribution, copyright notice, and permission notice requirement.

@lionelhorn
refactor: call transformError when error is thrown outside of actions
17f309e 
- Previously transformError was not called when an error occured in kernel.authenticate() for instance
- Enable better sanitization of errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcj marcj marcj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lionelhorn @marcj