adversarial augmentation #251
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voorhs
requested changes
Jul 25, 2025
There was a problem hiding this comment.
в целом все ок, работаем дальше!
помимо того что я написал в комментах есть следующие замечания:
- надо протестировать руками, прямо испортировать из библиотеки и позапускать
- надо добавить асинхронный режим работы
- надо исправить ошибки mypy
- надо запустить форматтер кода
когда будешь тестировать руками следи чтобы все лимиты опенаи не потратить)
чтобы добавить асинхронный режим работы можешь вдохновиться тем как у нас реализован эволвер
исправление ошибок mypy это вещь ситуативная для каждой ошибки, но если коротко то чаще всего тебе надо удостовериться
- что ты везде правильно указал принимаемые и возвращаемые типы
- что ты действительно подаешь правильные объекты на вход
- либо расставить
# type: ignore[тип ошибки]
autointent/generation/utterances/_adversarial/critic_human_like.py
Outdated
Show resolved
Hide resolved
autointent/generation/utterances/_adversarial/critic_human_like.py
Outdated
Show resolved
Hide resolved
autointent/generation/utterances/_adversarial/critic_human_like.py
Outdated
Show resolved
Hide resolved
autointent/generation/utterances/_adversarial/human_utterance_generator.py
Outdated
Show resolved
Hide resolved
autointent/generation/utterances/_adversarial/human_utterance_generator.py
Outdated
Show resolved
Hide resolved
voorhs
requested changes
Aug 2, 2025
autointent/generation/utterances/_adversarial/human_utterance_generator.py
Outdated
Show resolved
Hide resolved
autointent/generation/utterances/_adversarial/human_utterance_generator.py
Outdated
Show resolved
Hide resolved
voorhs
approved these changes
Aug 11, 2025
autointent/generation/utterances/_adversarial/human_utterance_generator.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.