Feat/upgrade net9 #42
Conversation
…ve service dependencies
…nd improve service dependencies
…clarity and formatting
…ing across multiple files
There was a problem hiding this comment.
Pull Request Overview
This pull request upgrades the DevStore microservices e-commerce application from .NET 6 to .NET 9, modernizing the codebase with updated dependencies, improved configuration patterns, and enhanced Docker infrastructure.
- Updates all projects to target .NET 9.0 with corresponding package upgrades
- Modernizes messaging infrastructure by replacing EasyNetQ with MassTransit for RabbitMQ integration
- Enhances Docker Compose setup with improved health checks, consolidated databases, and better service orchestration
Reviewed Changes
Copilot reviewed 81 out of 341 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Various Dockerfile files | Updated base images from .NET 6.0 to 9.0 |
| Multiple .csproj files | Upgraded target framework and NuGet packages to .NET 9 versions |
| appsettings files | Reformatted JSON arrays and updated RabbitMQ configuration structure |
| Docker compose files | Consolidated infrastructure with shared resources and improved orchestration |
| Core building blocks | Updated namespace declarations and modernized C# syntax patterns |
| Configuration classes | Replaced EasyNetQ with MassTransit and simplified API configuration |
| #endregion | ||
|
|
||
| #region Actions | ||
| return; |
There was a problem hiding this comment.
The return; statement makes the MapActions method unreachable. This will prevent API endpoints from being registered, breaking the application functionality.
| return; |
Copilot uses AI. Check for mistakes.
| await Task.Delay(delay); | ||
| } | ||
| // after a few attemps we give up | ||
| throw new DatabaseNotFoundException("Error waiting database. Check ConnectionString and ensure database exist"); |
There was a problem hiding this comment.
The error message contains a grammatical error. 'database exist' should be 'database exists'.
| throw new DatabaseNotFoundException("Error waiting database. Check ConnectionString and ensure database exist"); | |
| throw new DatabaseNotFoundException("Error waiting database. Check ConnectionString and ensure database exists"); |
Copilot uses AI. Check for mistakes.
src/services/DevStore.ShoppingCart.API/Services/ShoppingCartIntegrationHandler.cs
Outdated
Show resolved
Hide resolved
src/services/DevStore.ShoppingCart.API/Data/ShoppingCartContext.cs
Outdated
Show resolved
Hide resolved
| @@ -28,7 +21,7 @@ public ProviderConfiguration(string connString) | |||
| options => options.UseSqlServer(_connectionString, sql => sql.MigrationsAssembly(MigrationAssembly)); | |||
|
|
|||
| public Action<DbContextOptionsBuilder> MySql => | |||
| options => options.UseMySql(_connectionString, ServerVersion.AutoDetect(_connectionString), sql => sql.MigrationsAssembly(MigrationAssembly)); | |||
| options => options.UseMySQL(_connectionString, sql => sql.MigrationsAssembly(MigrationAssembly)); | |||
There was a problem hiding this comment.
[nitpick] The change from UseMySql with ServerVersion.AutoDetect to UseMySQL removes automatic server version detection. This could cause compatibility issues if the MySQL server version requires specific features or syntax.
| options => options.UseMySQL(_connectionString, sql => sql.MigrationsAssembly(MigrationAssembly)); | |
| options => options.UseMySql(_connectionString, ServerVersion.AutoDetect(_connectionString), sql => sql.MigrationsAssembly(MigrationAssembly)); |
Copilot uses AI. Check for mistakes.
…d certificate handling
Upgrade DevStore to .NET9