Skip to content

Use builtin python logging module #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use builtin python logging module #450

wants to merge 2 commits into from

Conversation

Hespe
Copy link
Member

@Hespe Hespe commented May 27, 2025

Description

Use the builtin python logging module instead of the standard print function. This makes the logging of Cheetah more flexible, e.g., downstream users can decide were to direct the logs to.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code and checked that formatting passes (required).
  • I have have fixed all issues found by flake8 (required).
  • I have ensured that all pytest tests pass (required).
  • I have run pytest on a machine with a CUDA GPU and made sure all tests pass (required).
  • I have checked that the documentation builds (required).

Note: We are using a maximum length of 88 characters per line.

@Hespe Hespe self-assigned this May 27, 2025
@Hespe Hespe added the enhancement New feature or request label May 27, 2025
@Hespe Hespe linked an issue May 27, 2025 that may be closed by this pull request
@Hespe
Copy link
Member Author

Hespe commented May 27, 2025

We might want to consider this in sync with #415. Maybe the cascading warning argument would no longer be necessary in fortran_namelist.py if users could supress these warnings by themselves. Not sure though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use python logging module instead of print
1 participant