[IMP] Docker compose file compatibility for Podman #835
+37
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the docker compose base file to allow running IRIS under Podman
on RHEL-based systems using podman-compose:
- explicitly expand variables in the `environment` block (e.g., use
`POSTGRES_USER=${POSTGRES_USER}` instead of just `POSTGRES_USER`);
- add SELinux labeling flags for file mounts (`z` or `Z` depending on
whether the mount is shared between multiple containers or not).
Also remove the `./certificates/` mount as it does not appear to be
referenced in the code (only `web_certificates` and `ldap` are used,
which are explicitly mounted by other rules).
Signed-off-by: Darius Mihai <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the docker compose base file to allow running IRIS under Podman on RHEL-based systems using podman-compose:
environmentblock (e.g., usePOSTGRES_USER=${POSTGRES_USER}instead of justPOSTGRES_USER);zorZdepending on whether the mount is shared between multiple containers or not).Also remove the
./certificates/mount as it does not appear to be referenced in the code (onlyweb_certificatesandldapare used, which are explicitly mounted by other rules).NB: the variable expansion may be an issue for some implementations of Docker or Podman, that may expose these variables in the command line for anyone able to list processes on the system (e.g., when running
ps auxusers may be able to see the command arguments like-e VAR=VALUE), but recent versions do not appear to have this issue.