Improving helm chart #868
Open
Improving helm chart #868
+102
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced .Values.ingress.tls.enabled with .Values.ingress.enableTls - Added enableTls and sslRedirect fields to values.yaml - Updated secretName placeholder in TLS configuration
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Much more usable Helm Chart! |
There was a problem hiding this comment.
Pull Request Overview
Refactors the Helm chart to add conditional deployments, secret-based environment injection, and richer ingress customization.
- Added
enableflags for RabbitMQ and PostgreSQL templates - Introduced
envFromSecretsupport foririsappandirisworkerto pull DB creds from Secrets - Enhanced Ingress with
enableTls,sslRedirect, andcustomAnnotations, plus dynamic backend defaults
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| deploy/kubernetes/charts/values.yaml | Added enable toggles, envFromSecret blocks, and updated ingress fields |
| deploy/kubernetes/charts/templates/rabbitmq.yaml | Wrapped RabbitMQ resources in a conditional on .Values.rabbitmq.enable |
| deploy/kubernetes/charts/templates/postgres.yaml | Wrapped PostgreSQL resources in a conditional on .Values.postgres.enable |
| deploy/kubernetes/charts/templates/iris_worker.yaml | Refactored DB env vars loop to use envFromSecret fallback |
| deploy/kubernetes/charts/templates/iris_app.yaml | Refactored DB env vars loop and updated service type reference |
| deploy/kubernetes/charts/templates/ingress.yaml | Improved ingress flags, annotations handling, and service backend defaults |
Comments suppressed due to low confidence (5)
deploy/kubernetes/charts/values.yaml:202
- The comment references
irisapp.envFromSecretin theirisworkersection; it should referenceirisworker.envFromSecretto match the values path.
## @param irisapp.envFromSecret Environment variables from a secret
deploy/kubernetes/charts/templates/rabbitmq.yaml:1
- Template checks
.Values.rabbitmq.enabledbutvalues.yamldefines the flag asrabbitmq.enable; update the reference or rename the value key to align.
{{- if .Values.rabbitmq.enabled }}
deploy/kubernetes/charts/templates/postgres.yaml:1
- Template uses
.Values.postgres.enabledbutvalues.yamldefinespostgres.enable; key names must match.
{{- if .Values.postgres.enabled }}
deploy/kubernetes/charts/templates/ingress.yaml:6
- This still references
ingress.annotationswhich has been removed; switch toingress.customAnnotationsor remove the block entirely.
annotations:
deploy/kubernetes/charts/templates/ingress.yaml:42
- Condition checks
.Values.ingress.enableTls.enabledbutenableTlsis a boolean invalues.yaml; use.Values.ingress.enableTlsor redefineenableTlsas an object.
{{- if and .Values.ingress.enableTls.enabled (gt (len .Values.ingress.tls.hosts) 0) }}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Helm chart to improve flexibility, security, and configuration clarity.
Changes
Motivation
These changes simplify configuration, improve secret management, and make the chart easier to customize for different environments.
Notes