Skip to content

Add AllowDraftPRs flag, disabled by default #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ri-roee
Copy link
Contributor

@ri-roee ri-roee commented Apr 8, 2024

Not tested yet in E2E flow, only in go testing

@motatoes
Copy link
Contributor

motatoes commented Apr 8, 2024

Thanks! I believe this is related to #1195 if I am not mistaken

@ri-roee
Copy link
Contributor Author

ri-roee commented Apr 15, 2024

@motatoes any chance you could test this locally? I can't seem to get my local stack up

@motatoes
Copy link
Contributor

@ri-roee hey! Not yet, hang in there its next on my list :D

@ri-roee
Copy link
Contributor Author

ri-roee commented Apr 23, 2024

Bump! :)

Copy link
Contributor

@motatoes motatoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just tested in https://github.com/diggerhq/test-digger-draft-disable with the flag and it seems to be working fine!

@motatoes motatoes merged commit faced4d into diggerhq:develop Apr 25, 2024
1 check passed
@ri-roee ri-roee deleted the ri-roee/allow-draft-prs-feature-flag branch April 25, 2024 21:28
ben-of-codecraft pushed a commit to ben-of-codecraft/digger that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants