migrate aws-sdk-go v1 to v2 #1350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larhauga
commented
Apr 18, 2024
motatoes
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
I have read through it and no flags from me. Very hard to ensure all correctness in a big change like this. You mentioned you are also working on a few additional tests for the dynamodb lock so those will be great to have as well. Given you have also run it a bit within your team I'm happy to merge as it is and deal with any regressions if they arrive later.
Should we merge @larhauga ?
|
@larhauga Perfect! Thanks for the good work here |
ben-of-codecraft
pushed a commit
to ben-of-codecraft/digger
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #1346, I noticed that the v1 version of the go sdk were in use.
This pull request migrates to the v2 sdk.
https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/