10802: digamma maps +/-0 to -/+inf #10825
Open
+45
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request and interest in making D better, @tedgin! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#10825" |
This adapts std.mathspecial.digamma so that it IEEE 754 way of handling +/-0.0, i.e., it treats them as values that are infinitesimally greater/less than zero. digamma(+0) = -inf and digamma(-0) = +inf. The DDOC and unittests were also updated.
|
The freebsd check timed out when it was nearly finished. Is it possible to rerun the check? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapts
std.mathspecial.digammaso that it IEEE 754 way of handling +/-0.0, i.e., it treats them as values that are infinitesimally greater/less than zero.digamma(+0.) == -real.infintyanddigamma(-0.) == +real.infinity. See #10802 for more information.The DDOC and unit tests are also updated.
Even though this is a small change, it results in a change in behavior. This would break any application that relies on
digamma(0.)evaluating toreal.nan. Therefore, I'm making this PR for the master branch.