Merge python-domino-environments into python-domino #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiiamelliott
requested review from
ddl-s-rodriguez,
ddl-ignacio-rossi and
ddl-haran-kumar
| response = self.request_manager.get(url).json() | ||
| return response | ||
|
|
||
| def get_environment(self, environment_id: str): |
There was a problem hiding this comment.
Not the most important thing, but we should probably have a get_revision method as well
There was a problem hiding this comment.
I was conflicted on this one.
There isn't a (documented) GET revision endpoint on the v1 API, but there is one on the v4 API.
I agree that it would be good if there was one, but I was trying to avoid the v4 endpoints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA
What issue does this pull request solve?
Managing Domino Compute Environments has been isolated to a separate
python-domino-environmentspackage, that is no longer maintained.With the changes to Domino Compute Environments in v6.1, there is a need to update the package to support the new functionality.
What is the solution?
Merging the separate
python-domino-environmentspackage intopython-dominoto simplify the experience of managing Domino Compute Environments.Updating the routes to use Domino's public Environments API endpoints.
Testing
Created a test script that tests each of the endpoints in the public API documentation, getting environments, creating new environments and revisions, updating the restricted revision, and then archiving them on completion.
Pull Request Reminders
References (optional)