Skip to content

Update data links to include required vars to not break drill down #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

Ninir
Copy link
Contributor

@Ninir Ninir commented Feb 10, 2025

Pull Request

Required Fields

🔎 What kind of change is it?

  • fix

🎯 What has been changed and why do we need it?

  • When having several clusters, the cluster var is missing when clicking a pod, which leads to a non-working tab.

Thanks for this repo! let me know if anything else is needed!

When having several clusters, the cluster var is missing when clicking a pod, which leads to a non-working tab.
@Ninir Ninir requested a review from dotdc as a code owner February 10, 2025 20:48
@dotdc dotdc self-assigned this Feb 11, 2025
@dotdc
Copy link
Owner

dotdc commented Feb 11, 2025

Hi @Ninir,
Thank you for the fix, can you bump the dashboard version at the end of the file?
Could you check if the query also needs to be updated in k8s-views-pods.json at line 218?

@Ninir Ninir changed the title Update Nodes<>Pods data link to pass cluster var Update data links to include required vars to not break drill down Feb 11, 2025
@Ninir
Copy link
Contributor Author

Ninir commented Feb 11, 2025

Hi @Ninir,
Thank you for the fix, can you bump the dashboard version at the end of the file?
Could you check if the query also needs to be updated in k8s-views-pods.json at line 218?

Sure! Let me check a few more things first now that it's fixed 🙏

@dotdc dotdc merged commit d4b599f into dotdc:master Feb 11, 2025
1 check passed
@dotdc
Copy link
Owner

dotdc commented Feb 11, 2025

Thank you for your contribution @Ninir !

@dotdc
Copy link
Owner

dotdc commented Feb 11, 2025

🎉 This PR is included in version 2.6.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dotdc dotdc added the released label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants