JIT: Fix ARM64 emitter tests #117768
Open
JIT: Fix ARM64 emitter tests #117768
+38
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-CodeGen-coreclr
There was a problem hiding this comment.
Pull Request Overview
This PR disables unit tests for unsupported SVE encodings and corrects incorrect branch conditions in the ARM64 SVE emitter.
- Wrap unsupported encoding tests in
codegenarm64test.cppwithALL_ARM64_EMITTER_UNIT_TESTS_SVE_UNSUPPORTEDguards. - Fix conditional checks in
emitarm64sve.cppto useINS_OPTS_SCALABLE_SandINS_OPTS_SCALABLE_Din the correct branches.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/coreclr/jit/emitarm64sve.cpp | Corrected conditional checks for INS_OPTS_SCALABLE_S/_D in SVE emitter format logic |
| src/coreclr/jit/codegenarm64test.cpp | Wrapped unsupported SVE encoding tests in #ifdef ALL_ARM64_EMITTER_UNIT_TESTS_SVE_UNSUPPORTED |
| @@ -4685,11 +4685,13 @@ void CodeGen::genArm64EmitterUnitTestsSve() | |||
| theEmitter->emitIns_R_R_R(INS_sve_urshlr, EA_SCALABLE, REG_V15, REG_P2, REG_V20, | |||
| INS_OPTS_SCALABLE_D); // URSHLR <Zdn>.<T>, <Pg>/M, <Zdn>.<T>, <Zm>.<T> | |||
|
|
|||
| #ifdef ALL_ARM64_EMITTER_UNIT_TESTS_SVE_UNSUPPORTED | |||
There was a problem hiding this comment.
[nitpick] Consider grouping the multiple unsupported encoding test blocks under a single #ifdef ALL_ARM64_EMITTER_UNIT_TESTS_SVE_UNSUPPORTED region to improve readability and reduce repetitive macro guards.
Copilot uses AI. Check for mistakes.
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Open
3 tasks
|
@dotnet/jit-contrib PTAL, thanks |
a74nh
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to discussion in #117660. This disables tests for unsupported encodings, and fixes a few incorrect branches in the SVE emitter. cc @dotnet/arm64-contrib