Skip to content

[clr-interp] Enable SIMD feature for callstubgenerator.cpp on supported architectures #117769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025

Conversation

kotlarmilos
Copy link
Member

@kotlarmilos kotlarmilos commented Jul 17, 2025

Description

This PR removes FEATURE_SIMD condition used in callstubgenerator.cpp for CORINFO_HFA_ELEM_VECTOR64 and CORINFO_HFA_ELEM_VECTOR128 return types.

This change should enable 11 methods on the startup path.

Copy link
Contributor

Tagging subscribers to this area: @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

@kg
Copy link
Member

kg commented Jul 17, 2025

Is this necessary for startup to work?

@kg
Copy link
Member

kg commented Jul 17, 2025

LGTM but I'm not a build expert

@jkotas
Copy link
Member

jkotas commented Jul 17, 2025

Do you expect that there will be more uses FEATURE_SIMD uses in the VM?

If it is just about the one use in

#ifdef FEATURE_SIMD
, I think it can be deleted instead. I do not expect we would ever want to support building Arm64 without SIMD support in the calling convention.

@kotlarmilos
Copy link
Member Author

I don't expect that there will be more FEATURE_SIMD uses in the VM. Removed as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants