Skip to content

Add code coverage for RadioButtonBaseAdapter #13726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Jul 22, 2025

Related #13442

Proposed changes

Add unit test file:RadioButtonBaseAdapterTests.cs for public/protected methods/properties of the RadioButtonBaseAdapter.cs

Microsoft Reviewers: Open in CodeFlow

@Zheng-Li01 Zheng-Li01 requested a review from a team as a code owner July 22, 2025 02:44
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Jul 22, 2025
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

❌ Patch coverage is 92.47312% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.92382%. Comparing base (7c04597) to head (63bd6a6).
⚠️ Report is 36 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13726         +/-   ##
===================================================
+ Coverage   76.90689%   76.92382%   +0.01693%     
===================================================
  Files           3260        3263          +3     
  Lines         643088      643837        +749     
  Branches       47601       47639         +38     
===================================================
+ Hits          494579      495264        +685     
- Misses        144845      144902         +57     
- Partials        3664        3671          +7     
Flag Coverage Δ
Debug 76.92382% <92.47312%> (+0.01693%) ⬆️
integration 18.99836% <ø> (+0.01046%) ⬆️
production 51.62100% <ø> (+0.04539%) ⬆️
test 97.41898% <92.47312%> (-0.00254%) ⬇️
unit 49.02282% <ø> (+0.06325%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ricardobossan
ricardobossan previously approved these changes Jul 24, 2025
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a small comment, all LGTM!

@ricardobossan ricardobossan added the waiting-author-feedback The team requires more information from the author label Jul 24, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jul 25, 2025
ricardobossan
ricardobossan previously approved these changes Jul 28, 2025
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ricardobossan ricardobossan merged commit fb6216b into dotnet:main Aug 1, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Aug 1, 2025
@Zheng-Li01 Zheng-Li01 deleted the Add_code_coverage_for_RadioButtonBaseAdapter branch August 4, 2025 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants