fix(dracut.sh): skip README for AMD microcode generation #2544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
champtar
reviewed
Oct 30, 2023
This file was added in https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/amd-ucode/README?id=89ec6198f13d1007563ff87aae5de209e993be07 and it should be skipped. Fixes dracutdevs#2541
aafeijoo-suse
force-pushed
the
fix-2541
branch
from
2d41257 to
c1a69b8
Compare
champtar
approved these changes
Oct 30, 2023
LaszloGombos
approved these changes
Oct 30, 2023
lnykryn
approved these changes
Oct 31, 2023
| @@ -2154,6 +2154,8 @@ if [[ $early_microcode == yes ]]; then | |||
| done | |||
| for i in $_fwdir/$_fw/$_src; do | |||
| [[ -e $i ]] || continue | |||
| # skip README{.xz,.zst,...} | |||
| str_starts "$i" "$_fwdir/$_fw/README" && continue | |||
There was a problem hiding this comment.
this just puts a bandage on a symptom of the problem, instead of fixing the actual problem: the proper way would be to only cat files that match the glob *.bin (for amd) or ??-??-?? (for intel)
|
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file was added in https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/amd-ucode/README?id=89ec6198f13d1007563ff87aae5de209e993be07 and it should be skipped.
Checklist
Fixes #2541