Add basic for-each-ref command #239
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driusan
reviewed
Mar 14, 2019
| } | ||
|
|
||
| flags.Parse(args) | ||
| refs, err := git.ShowRef(c, git.ShowRefOptions{}, []string{}) |
There was a problem hiding this comment.
I think this part that does the work should be in the git package to be consistent with other commands.
There was a problem hiding this comment.
@sirnewton01 ping.. are you going to get a chance to refactor this, or do you want me to pick it up? I don't think it should be a lot of work.
There was a problem hiding this comment.
I can have a look at doing the refactor at some point. Sorry, just really busy at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just enough to satisfy some of what the t5516-fetch-pull tests need. It supports the basic format only and commits only. The pattern doesn't support wildcards yet.