-
Notifications
You must be signed in to change notification settings - Fork 493
Added a function to allow inverting the output from a GPIO pin #3039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
invectorlabs
wants to merge
2
commits into
earlephilhower:master
Choose a base branch
from
invectorlabs:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+83
−2
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
|
||
/* | ||
GPIOInvert | ||
|
||
This example shows how to enable the pin output inversion mechanism for a GPIO pin. | ||
|
||
This example code is in the public domain. | ||
*/ | ||
|
||
int led = LED_BUILTIN; // the pin the LED is attached to | ||
|
||
// the setup routine runs once when you press reset: | ||
void setup() { | ||
// declare pin to be an output: | ||
pinMode(led, OUTPUT); | ||
// Now enable the pin inversion function. | ||
// This must be done after the pinMode command. | ||
setPinInvert(led, true); | ||
|
||
while(!Serial) | ||
delay(10); | ||
|
||
Serial.begin(115200); | ||
} | ||
|
||
// the loop routine runs over and over again forever: | ||
void loop() { | ||
// Turn the LED off | ||
digitalWrite(led, HIGH); | ||
Serial.println("LED off"); | ||
delay(2000); | ||
|
||
// Turn the LED on | ||
digitalWrite(led, LOW); | ||
Serial.println("LED on"); | ||
delay(2000); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While adding this in
pinMode
seems fine, I think deleting here will break the case where you have someone else controlling the pin (i.e.tone
which uses PIO) and then you stop that process and thendigitalWrite
. Let me whip up a simple test case...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this breaks normal functionality. Can you re-add the line?
Simple example blinks after analogWrite with
master
, remains PWN (connected to PIO) with this patchThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gpio_set_function clears the override register so I will need to save the state somehow. I'll get back....