Fix macOS RPATH handling and install rules for Iceoryx platform modules #2475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
This PR improves compatibility with MacOS by correctly setting RPATH and install properties in key CMakeLists.txt files for iceoryx_binding_c and iceoryx_hoofs, particularly addressing dynamic linking of the iceoryx_platform module.
Changes include:
Added explicit INSTALL_RPATH and BUILD_RPATH for MacOS
Fixed missing install rule for iceoryx_platform
Ensured proper MACOSX_RPATH behavior
Tested with ros2_rolling and colcon build using --symlink-install on MacOS 12.7.6 x86_64 with SIP enabled.
Pre-Review Checklist for the PR Author
doc/website/release-notes/iceoryx-unreleased.md
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References
Relates to MacOS build compatibility for ROS2 Rolling and downstream packages using colcon with symlink-install.
Targets compatibility with MacOS 12.7.6 (x86_64)
Apple SIP remains enabled during testing
All patched files build cleanly with
colcon build --symlink-install
No runtime logic or public API modified — strictly build system compatibility
Closes TBD