Park performance investigation #22181
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thallium
force-pushed
the
park1
branch
3 times, most recently
from
0feb1a6 to
54e5a4e
Compare
|
@tajila the changes are ready to be built. |
|
The title should summarize what this will do; perhaps "Improve park performance"? |
|
jenkins compile xlinux jdk17 |
tajila
reviewed
Jul 10, 2025
runtime/vm/threadhelp.cpp
Outdated
|
|
||
| rc = omrthread_park(millis, nanos); | ||
|
|
||
| Trc_VM_ThreadHelp_timeCompensationHelper_parkWaited(vmThread, j9time_nano_time()-currentTime, policy, earlyBreak, count, vmThread->parkRate); |
There was a problem hiding this comment.
include context switch rate
|
jenkins compile xlinux jdk17 |
Introduce the ability to spin on park in order to address pathological cases where application behaviour frequently parks/unparks. Signed-off-by: tajila <[email protected]>
Signed-off-by: Gengchen Tuo <[email protected]>
Signed-off-by: Gengchen Tuo <[email protected]>
|
@tajila can you launch a build again since the comparison need to be reversed? |
|
jenkins compile xlinux jdk17 |
A non-empty description would be helpful as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to improve the performance of
park()by sleeping or spinning before calling system park based on various metrics. Right now we're still at the phase of evaluating the impact of different sleep/spin configurations across different workloads.