Fix x86-32 private linkage for dispatchVirtual #22268
Merged
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhall2
force-pushed
the
x86-32_dispatchVirtual_fix_linkage
branch
2 times, most recently
from
4509dda to
b63c1ce
Compare
jdmpapin
reviewed
Jul 24, 2025
nbhuiyan
reviewed
Jul 25, 2025
matthewhall2
force-pushed
the
x86-32_dispatchVirtual_fix_linkage
branch
4 times, most recently
from
cdcd084 to
6e1e8c2
Compare
jdmpapin
reviewed
Aug 21, 2025
matthewhall2
force-pushed
the
x86-32_dispatchVirtual_fix_linkage
branch
from
6e1e8c2 to
6975b4f
Compare
Changes dispatchVirtual to always use long args for the jit entry point and jit vft offset so the index register is properly marked in linkage. Disables check for j2iThunks for x86-32 Issue: eclipse-openj9#18751 Signed-off-by: Matthew Hall <[email protected]>
matthewhall2
force-pushed
the
x86-32_dispatchVirtual_fix_linkage
branch
from
6975b4f to
c23511f
Compare
jdmpapin
approved these changes
Aug 26, 2025
|
Jenkins test sanity xlinux jdk17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the VTable index argument register was not marked as such on x86-32 for 32-bit arguments, which caused issues when invoking MethodHandles through dispatchVirtual.
This changes dispatchVirtual to always use
longarg0 for the jit entry point and jit vft offset so the index register is marked properly in linkage.Issue: #18751