Skip to content

include link stats in adminspace #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

wyfo
Copy link
Contributor

@wyfo wyfo commented Apr 22, 2025

No description provided.

@wyfo wyfo requested a review from OlivierHecart April 22, 2025 14:52
@wyfo wyfo added the internal Changes not included in the changelog label Apr 22, 2025
Copy link

PR missing one of the required labels: {'internal', 'dependencies', 'enhancement', 'documentation', 'breaking-change', 'bug', 'new feature'}

Copy link

codecov bot commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 71.54%. Comparing base (dc7ae1e) to head (2b6298f).

Files with missing lines Patch % Lines
zenoh/src/net/runtime/adminspace.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1916      +/-   ##
==========================================
+ Coverage   71.50%   71.54%   +0.03%     
==========================================
  Files         363      363              
  Lines       65032    65046      +14     
==========================================
+ Hits        46501    46536      +35     
+ Misses      18531    18510      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OlivierHecart
Copy link
Contributor

I wound have expected the link stats to also appear in the open metrics report with something like:
tx_z_put_msgs{space="user",zid="d4067d35b7ee60bfaf9b80cb94aac1aa",link="13573168778386999397"}

@OlivierHecart
Copy link
Contributor

I wound have expected the link stats to also appear in the open metrics report with something like:
tx_z_put_msgs{space="user",zid="d4067d35b7ee60bfaf9b80cb94aac1aa",link="13573168778386999397"}

Let's address the open metrics report in another PR.

@OlivierHecart OlivierHecart merged commit b146561 into eclipse-zenoh:main May 13, 2025
15 of 17 checks passed
@OlivierHecart OlivierHecart deleted the ZEN-550-Remote-link-usage-monitoring branch May 13, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes not included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants