[ZEN-587] Make Reply::replier_id() return an EntityGlobalId
#2052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'bug', 'dependencies', 'documentation', 'new feature', 'breaking-change', 'enhancement', 'internal'} |
oteffahi
added
the
breaking-change
oteffahi
changed the title
replied_id() return an EntityGlobalId
oteffahi
changed the title
replied_id() return an EntityGlobalIdReply::replied_id() return an EntityGlobalId
oteffahi
changed the title
Reply::replied_id() return an EntityGlobalIdReply::replier_id() return an EntityGlobalId
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2052 +/- ##
==========================================
- Coverage 71.01% 70.93% -0.08%
==========================================
Files 367 367
Lines 62241 62175 -66
==========================================
- Hits 44201 44106 -95
- Misses 18040 18069 +29 ☔ View full report in Codecov by Sentry. |
DenisBiryukov91
approved these changes
Jul 21, 2025
This was referenced Jul 22, 2025
This was referenced Jul 22, 2025
oteffahi
changed the title
Reply::replier_id() return an EntityGlobalIdReply::replier_id() return an EntityGlobalId
sashacmc
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the replied_id on
Replymessages to anEntityGlobalIdinstead of just aZenohId.This is a breaking change.
Sister PRs will be made on affected Zenoh bindings.