feat:Implement PDC Maturity email notification #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SherinKR
requested changes
Jun 11, 2025
pdc_management/pdc_management/doctype/pdc_management_settings/pdc_management_settings.json
Outdated
Show resolved
Hide resolved
pdc_management/pdc_management/doctype/pdc_management_settings/pdc_management_settings.py
Outdated
Show resolved
Hide resolved
pdc_management/pdc_management/doctype/pdc_management_settings/pdc_management_settings.py
Outdated
Show resolved
Hide resolved
pdc_management/pdc_management/doctype/pdc_management_settings/pdc_management_settings.py
Outdated
Show resolved
Hide resolved
pdc_management/pdc_management/doctype/pdc_management_settings/pdc_management_settings.py
Outdated
Show resolved
Hide resolved
pdc_management/pdc_management/doctype/pdc_management_settings/pdc_management_settings.py
Show resolved
Hide resolved
pdc_management/pdc_management/doctype/pdc_management_settings/pdc_management_settings.py
Outdated
Show resolved
Hide resolved
pdc_management/pdc_management/doctype/pdc_payment_reference/pdc_payment_reference.json
Outdated
Show resolved
Hide resolved
pdc_management/pdc_management/doctype/post_dated_cheque/post_dated_cheque.json
Show resolved
Hide resolved
SherinKR
requested changes
Jun 11, 2025
Comment on lines
44
to
46
| for user in internal_users | ||
| if frappe.db.get_value("User", user, "enabled") and frappe.db.get_value("User", user, "email") | ||
| ] |
Comment on lines
68
to
75
| for email in recipients: | ||
| frappe.sendmail( | ||
| recipients=[email], | ||
| subject=subject, | ||
| message=message, | ||
| reference_doctype="Post Dated Cheque", | ||
| reference_name=pdc["name"] | ||
| ) |
Comment on lines
+83
to
+88
| SELECT ce.email_id | ||
| FROM `tabDynamic Link` dl | ||
| JOIN `tabContact Email` ce ON ce.parent = dl.parent | ||
| WHERE dl.link_doctype = %s AND dl.link_name = %s | ||
| ORDER BY ce.is_primary DESC | ||
| LIMIT 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
##Feature Description
This PR introduces a scheduled notification system that alerts internal users and external parties when a Post Dated Cheque (PDC) is nearing its maturity date.
##Solution Description
1.Created doctype PDC Management Settings with fields
Maturity Notification Before
Maturity Notification Template
Notification Role
2.Created PDC Payment reference - child table
Type
Name
Amount
Outstanding amount
Allocated amount
Pdc clearance date
3.Scheduled email notification if the maturity date is approaching.
Sends email to:
All internal users with the specified role (if configured).
The primary email of the linked Supplier/Customer contact (if available).
##Output Screenshots
##Areas Affected and Ensured
PDC doctype.
##Tested On
Google Chrome