-
Notifications
You must be signed in to change notification settings - Fork 128
feat(a11y): General Accessible Chart Information #2683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
walterra
wants to merge
41
commits into
elastic:main
Choose a base branch
from
walterra:a11y-desc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
…criptions and axis information
…hart descriptions
…ture and remove unnecessary wrapper div
…ntext and actual value ranges
…owing ChartSelectors pattern
…and single values
… reader selectors
…troducing generic ChartLabelData interface
…specific code area
…specific code area
…favor of existing utility function
…ngs with clearer naming
…ription component
…erated descriptions
…th automated description validation
…ity text in e2e tests
…c test assertions - Fix invalid HTML structure by moving ScreenReaderSummary components outside canvas elements in Goal and Heatmap charts - Update e2e test helpers to handle multiple screen reader elements more robustly - Replace generic accessibility content checks with specific expected text assertions in all a11y tests - Improve waitForA11yContent to use proper Playwright locator patterns 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
✅ Successful Deployment (build#5016) - 77971f3 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WORK IN PROGRESS
Details
Issues
Part of #36386.
Checklist
:xy
,:partition
):interactions
,:axis
)closes #123
,fixes #123
)packages/charts/src/index.ts
light
anddark
themes