Test building archetypes #2796
Test building archetypes #2796
Conversation
cmd/build.go
Outdated
| @@ -72,7 +72,7 @@ func buildCommandAction(cmd *cobra.Command, args []string) error { | |||
| } | |||
| logger.Debugf("Use build directory: %s", buildDir) | |||
|
|
|||
| targets, err := docs.UpdateReadmes(packageRoot) | |||
| targets, err := docs.UpdateReadmes(packageRoot, "") | |||
There was a problem hiding this comment.
Could buildDir be used here as that folder has been created above?
| targets, err := docs.UpdateReadmes(packageRoot, "") | |
| targets, err := docs.UpdateReadmes(packageRoot, buildDir) |
There was a problem hiding this comment.
Umm, seeing that actually maybe we don't need all the magic below to create the build dir, as is being created explicitly here. Maybe I can remove some more code.
There was a problem hiding this comment.
Tried to make the build dir always explicit, but there are many things that end up using a builder and would need to be refactored to receive also a build dir. For example the installers, and resources.FleetPackage.
Though I have also found that the value returned by BuildPackagesDirectory is expected to have the packages part, so I have fixed that, and then we can use buildDir here.
Changed in ead911b.
💚 Build Succeeded
History
cc @jsoriano |
After creating packages from archetypes, they may contain errors that are only discovered on update or build time. Perform a full build of the created packages to detect these issues.
This would have detected a missing function in a template in #2707.
This change also allows to build packages in a target build directory.