Skip to content

Enable failure store for APM datastreams #131296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 17, 2025
Merged

Enable failure store for APM datastreams #131296

merged 9 commits into from
Jul 17, 2025
+9 −1

Conversation

rubvs
Copy link
Contributor

@rubvs rubvs commented Jul 15, 2025 •
edited
Loading

Closes https://github.com/elastic/apm-managed-service/issues/1541

Enable failure store for APM datastreams for >=9.2, see Slack.

Supersedes #125672

@rubvs rubvs added >non-issue :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team auto-backport Automatically create backport pull requests when merged labels Jul 15, 2025
@rubvs rubvs marked this pull request as ready for review July 15, 2025 18:04
@rubvs rubvs requested a review from a team as a code owner July 15, 2025 18:04
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@rubvs rubvs mentioned this pull request Jul 15, 2025
Closed
simitt
simitt reviewed Jul 16, 2025
View reviewed changes
Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, but this should likely also have an entry in the docs/changes. Will approve once changelog is added.

Please also bring this back to the changelog for apm-server v9.2 then.

@rubvs rubvs changed the title mis: enable failure store for APM datastreams Enable failure store for APM datastreams Jul 16, 2025
@rubvs
Copy link
Contributor Author

rubvs commented Jul 16, 2025

Added the changes for OTEL datastreams in a new PR to simplify changelog: #131395

@elasticsearchmachine
Copy link
Collaborator

Hi @rubvs, I've created a changelog YAML for you.

dakrone
dakrone reviewed Jul 16, 2025
View reviewed changes
@rubvs rubvs merged commit 280793d into elastic:main Jul 17, 2025
33 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

There are no branches to backport to. Aborting.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 131296

@ericywl ericywl mentioned this pull request Jul 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakrone dakrone dakrone left review comments

@simitt simitt simitt approved these changes

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged backport pending :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >enhancement Team:Data Management Meta label for data/management team v9.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rubvs @elasticsearchmachine @dakrone @simitt @1pkg