[ML] Remove SageMaker Elastic updates #131301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than silently drop the payload, throw a validation error when Users try to send task settings in the update payload for SageMaker inference with the Elastic API.
prwhelan
added
>non-issue
:ml
prwhelan
commented
Jul 15, 2025
| @@ -88,12 +88,6 @@ default SdkBytes requestBytes(SageMakerModel model, SageMakerInferenceRequest re | |||
|
|
|||
| @Override | |||
| default SageMakerElasticTaskSettings apiTaskSettings(Map<String, Object> taskSettings, ValidationException validationException) { | |||
| if (taskSettings != null && (taskSettings.isEmpty() == false)) { | |||
| validationException.addValidationError( | |||
There was a problem hiding this comment.
The calling code adds validation errors for "extra settings" already, so this error is redundant in this location - we're moving it into the update call path instead where there is no error but should be
|
Pinging @elastic/ml-core (Team:ML) |
jonathan-buttner
approved these changes
Jul 15, 2025
This was referenced Jul 16, 2025
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Jul 16, 2025
Rather than silently drop the payload, throw a validation error when Users try to send task settings in the update payload for SageMaker inference with the Elastic API.
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Jul 16, 2025
Rather than silently drop the payload, throw a validation error when Users try to send task settings in the update payload for SageMaker inference with the Elastic API.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 16, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 16, 2025
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Jul 22, 2025
…king * upstream/main: Mark watcher NotMultiProjectCapable and replace deprecated multi-project methods (elastic#131313) Enable force inference endpoint deleting for invalid models and after stopping model deployment fails (elastic#129090) [ML] Remove SageMaker Elastic updates (elastic#131301) Refactor AsyncSearchErrorTraceIT to use assertBusy (elastic#131328)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than silently drop the payload,
throw a validation error when Users try to send task settings
in the update payload for SageMaker inference with the
Elastic API.