[Logstash] Move elastic_integration plugin usage to ES logstash-bridge.
#131486
+331
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h default method to avoid required interface implementation.
… the bridge. Processor definitions also moved to the bridge. Module simplofications.
elasticsearchmachine
added
v9.2.0
external-contributor
…k spatial/wildcard/mapper-constant modules.
elasticsearchmachine
added
the
needs:triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why we are doing this?
A bit info about plugin
[
elastic_integration](plugin https://github.com/elastic/logstash-filter-elastic_integration) retrieves ingest pipelines for the data stream and runs Elastic integrations it resolved. In order to do so, It internally embeds the ES sources (ingest processors, ingest plugins, etc...), will be regularly built against ES (with all active branches) and released as a [ruby gem]https://rubygems.org/gems/logstash-filter-elastic_integrationThe problem we are facing
When ES interfaces change (for e.g, GeoIP), result in plugin build breakage. So, we in the end, came up with a solution to introduce an agreement between
elastic_integrationplugin and ES,logstash-bridgemodule! The module wraps up any classes/modules the plugin depends on and whenever interface changes, developers will apply directly to the bridge Wrapper interfaces will stay without change. This will guarantee the plugin stability.What this PR does?
It migrates majority plugin interface usages to the bridge. This investigation shows the plugin usage details.
Exports following modules to make visible in logstash-bridge:
ingest-user-agent(org.elasticsearch.ingest.useragent)mapper-constant-keyword(org.elasticsearch.xpack.constantkeyword)x-pack:plugin:redact(org.elasticsearch.xpack.redact):x-pack:plugin:spatial(only required ones:org.elasticsearch.xpack.spatial,org.elasticsearch.xpack.spatial.commonandorg.elasticsearch.xpack.spatial.search.aggregations.bucket.geogrid):x-pack:plugin:wildcard(org.elasticsearch.xpack.wildcard)