Migrate x-pack-enrich legacy rest tests to new test framework #131743

mosche · 2025-07-23T08:35:06Z

Migrate x-pack-enrich legacy rest tests to new test framework

elasticsearchmachine · 2025-07-23T08:35:31Z

Pinging @elastic/es-core-infra (Team:Core/Infra)

mosche · 2025-07-23T08:39:44Z

YAML tests are failing in cleanUpCluster. Not sure how to solve, if preserving the data I get conflicts later.

method [DELETE], host [http://[::1]:53400], URI [*,-.ds-ilm-history-*,-.ds-.slm-history-*,-.ds-.watcher-history-*,-.ds-.triggered_watches-*?expand_wildcards=open%2Cclosed%2Chidden], status line [HTTP/1.1 400 Bad Request]
{"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"index [.ds-my-ds-2025.07.23-000001] is the write index for data stream [my-ds] and cannot be deleted"}],"type":"illegal_argument_exception","reason":"index [.ds-my-ds-2025.07.23-000001] is the write index for data stream [my-ds] and cannot be deleted"},"status":400}
org.elasticsearch.client.ResponseException: method [DELETE], host [http://[::1]:53400], URI [*,-.ds-ilm-history-*,-.ds-.slm-history-*,-.ds-.watcher-history-*,-.ds-.triggered_watches-*?expand_wildcards=open%2Cclosed%2Chidden], status line [HTTP/1.1 400 Bad Request]
{"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"index [.ds-my-ds-2025.07.23-000001] is the write index for data stream [my-ds] and cannot be deleted"}],"type":"illegal_argument_exception","reason":"index [.ds-my-ds-2025.07.23-000001] is the write index for data stream [my-ds] and cannot be deleted"},"status":400}
	at __randomizedtesting.SeedInfo.seed([2D63C9B58475A573:A537F66F2A89C88B]:0)
	at org.elasticsearch.client.RestClient.convertResponse(RestClient.java:351)
	at org.elasticsearch.client.RestClient.performRequest(RestClient.java:317)
	at org.elasticsearch.client.RestClient.performRequest(RestClient.java:292)
	at org.elasticsearch.test.rest.ESRestTestCase.wipeAllIndices(ESRestTestCase.java:1246)
	at org.elasticsearch.test.rest.ESRestTestCase.wipeCluster(ESRestTestCase.java:958)
	at org.elasticsearch.test.rest.ESRestTestCase.cleanUpCluster(ESRestTestCase.java:622)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)

mark-vieira · 2025-07-23T19:31:35Z

x-pack/plugin/enrich/build.gradle

+
+  clusterModules project(xpackModule('monitoring'))
+  clusterModules project(xpackModule('ilm'))
+  clusterModules project(xpackModule('wildcard'))
 }

 addQaCheckDependencies(project)


We can remove this since we've gotten rid of the QA projects.

mark-vieira · 2025-07-23T19:35:46Z

YAML tests are failing in cleanUpCluster. Not sure how to solve, if preserving the data I get conflicts later.

Hmm, I don't see why it would be different. The only change we've really made here behaviorally is switching away from the default distribution which certainly could matter. Might be worth trying to see if using the default distro resolves the failures. Perhaps there's another missing module here we implicitly rely on?

mosche · 2025-07-24T14:42:33Z

Thanks @mark-vieira, using the default distro the YAML tests pass. No idea why 🤷

…c#131743)

elasticsearchmachine · 2025-07-24T16:09:27Z

💔 Backport failed

Status	Branch	Result
✅	9.1
❌	8.19	Commit could not be cherrypicked due to conflicts
✅	9.0
❌	8.18	Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 131743

… (#131857)

…c#131743) (cherry picked from commit 71130a6) # Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/RestrictedBuildApiService.java # x-pack/plugin/enrich/build.gradle # x-pack/plugin/enrich/qa/rest-with-advanced-security/build.gradle # x-pack/plugin/enrich/qa/rest-with-security/build.gradle # x-pack/plugin/enrich/qa/rest/build.gradle

mosche · 2025-07-25T07:46:30Z

@mark-vieira actually, noticed one thing... how's FIPS working in the new test framework, that requires additional jars doesn't it?
I've previously tested this locally with FIPS enabled, but now I'm wondering if this wasn't working as expected (-Dtests.fips.enabled=true not being forwarded to the local cluster) and this should have failed instead (due to the basic license)?

…c#131743) (cherry picked from commit 71130a6) # Conflicts: # x-pack/plugin/enrich/build.gradle # x-pack/plugin/enrich/qa/rest-with-advanced-security/build.gradle # x-pack/plugin/enrich/qa/rest-with-security/build.gradle # x-pack/plugin/enrich/qa/rest/build.gradle

mosche · 2025-07-25T08:26:30Z

💚 All backports created successfully

Status	Branch	Result
✅	8.19
✅	8.18

Questions ?

Please refer to the Backport tool documentation

…king * upstream/main: (90 commits) Register a blob cache long counter metric for total evicted regions (elastic#131862) Move plan attribute resolution to its own component (elastic#131830) Make restore support multi-project (elastic#131661) Use logically more correct expression (elastic#131869) [ES|QL] Change equals and hashcode for ConstantNullBlock (elastic#131817) Update `TransportVersion` to support a new model (elastic#131488) Correct slow log user for RCS 2.0 (elastic#130140) Revert "Remove 8.17 from dev branches" Mute org.elasticsearch.compute.aggregation.ValuesBytesRefGroupingAggregatorFunctionTests testSomeFiltered elastic#131878 Remove 8.17 from dev branches Revert "CompressorFactory.compressor (elastic#131655)" (elastic#131866) Add fast path for single value in VALUES aggregator (elastic#130510) Resolve inference release tests failing due to missing feature flag (elastic#131841) [Docs] Replace placeholder URLs (elastic#131309) CompressorFactory.compressor (elastic#131655) add availability info for speed loading setting (elastic#131714) [Logstash] Move `elastic_integration` plugin usage to ES logstash-bridge. (elastic#131486) Migrate x-pack-enrich legacy rest tests to new test framework (elastic#131743) Fix plugin example test failures due to deprecation warning (elastic#131819) Remove deprecated function isNotNullAndFoldable (elastic#130944) ...

… (#131856)

mark-vieira · 2025-07-25T15:09:50Z

@mark-vieira actually, noticed one thing... how's FIPS working in the new test framework, that requires additional jars doesn't it? I've previously tested this locally with FIPS enabled, but now I'm wondering if this wasn't working as expected (-Dtests.fips.enabled=true not being forwarded to the local cluster) and this should have failed instead (due to the basic license)?

It works more or less the same way. See FipsEnabledClusterConfigProvider.

Migrate x-pack-enrich legacy rest tests to new test framework

048881b

mosche requested a review from a team July 23, 2025 08:35

mosche added >test Issues or PRs that are addressing/adding tests :Core/Infra/Core Core issues without another label >refactoring labels Jul 23, 2025

elasticsearchmachine added Team:Core/Infra Meta label for core/infra team v9.2.0 labels Jul 23, 2025

remove from legacy test map

637c44f

mosche requested a review from a team as a code owner July 23, 2025 08:46

[CI] Auto commit changes from spotless

1b06799

mosche added auto-backport Automatically create backport pull requests when merged v9.1.1 v8.19.1 v9.0.5 v8.18.5 labels Jul 23, 2025

mark-vieira approved these changes Jul 23, 2025

View reviewed changes

mosche added 4 commits July 24, 2025 09:32

fix yamlRestTest

19be8ed

Merge branch 'main' into legacytests/migrate-x-pack-enrich

d8d0844

Merge branch 'main' into legacytests/migrate-x-pack-enrich

7ef2c8d

Merge branch 'main' into legacytests/migrate-x-pack-enrich

48419df

mosche merged commit 71130a6 into elastic:main Jul 24, 2025
33 checks passed

mosche added a commit to mosche/elasticsearch that referenced this pull request Jul 24, 2025

Migrate x-pack-enrich legacy rest tests to new test framework (elasti…

267c048

…c#131743)

mosche mentioned this pull request Jul 24, 2025

[9.1] Migrate x-pack-enrich legacy rest tests to new test framework (#131743) #131856

Merged

mosche added a commit to mosche/elasticsearch that referenced this pull request Jul 24, 2025

Migrate x-pack-enrich legacy rest tests to new test framework (elasti…

7d8bd34

…c#131743)

mosche mentioned this pull request Jul 24, 2025

[9.0] Migrate x-pack-enrich legacy rest tests to new test framework (#131743) #131857

Merged

elasticsearchmachine added the backport pending label Jul 24, 2025

elasticsearchmachine pushed a commit that referenced this pull request Jul 24, 2025

Migrate x-pack-enrich legacy rest tests to new test framework (#131743)…

5535de3

… (#131857)

mosche mentioned this pull request Jul 25, 2025

[8.19] Migrate x-pack-enrich legacy rest tests to new test framework (#131743) #131906

Open

mosche mentioned this pull request Jul 25, 2025

[8.18] Migrate x-pack-enrich legacy rest tests to new test framework (#131743) #131909

Open

elasticsearchmachine pushed a commit that referenced this pull request Jul 25, 2025

Migrate x-pack-enrich legacy rest tests to new test framework (#131743)…

0596b02

… (#131856)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Migrate x-pack-enrich legacy rest tests to new test framework #131743

Migrate x-pack-enrich legacy rest tests to new test framework #131743

mosche commented Jul 23, 2025

Uh oh!

elasticsearchmachine commented Jul 23, 2025

Uh oh!

mosche commented Jul 23, 2025

Uh oh!

mark-vieira Jul 23, 2025

Uh oh!

mark-vieira commented Jul 23, 2025

Uh oh!

mosche commented Jul 24, 2025

Uh oh!

Uh oh!

elasticsearchmachine commented Jul 24, 2025

Uh oh!

mosche commented Jul 25, 2025

Uh oh!

mosche commented Jul 25, 2025

Uh oh!

mark-vieira commented Jul 25, 2025

Uh oh!

Uh oh!

Migrate x-pack-enrich legacy rest tests to new test framework #131743

Migrate x-pack-enrich legacy rest tests to new test framework #131743

Conversation

mosche commented Jul 23, 2025

Uh oh!

elasticsearchmachine commented Jul 23, 2025

Uh oh!

mosche commented Jul 23, 2025

Uh oh!

mark-vieira Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

mark-vieira commented Jul 23, 2025

Uh oh!

mosche commented Jul 24, 2025

Uh oh!

Uh oh!

elasticsearchmachine commented Jul 24, 2025

💔 Backport failed

Uh oh!

mosche commented Jul 25, 2025

Uh oh!

mosche commented Jul 25, 2025

💚 All backports created successfully

Questions ?

Uh oh!

mark-vieira commented Jul 25, 2025

Uh oh!

Uh oh!