DiskBBQ Prefetch vectors during merge #132958
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
elasticsearchmachine
added
the
Team:Search Relevance
benwtrent
commented
Aug 14, 2025
Comment on lines
+397
to
+399
| for (int o : ord) { | ||
| vectors.prefetch(o * vectorLength, vectorLength); | ||
| } |
There was a problem hiding this comment.
All this change for these three lines...LOL
john-wagster
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps immensely in lower memory environments, helping merging significantly.
I chose 4 at a time as that seemed better than 1, and not too extreme. I could be convinced to go higher. I didn't really benchmark higher values (I can do that if necessary).