Skip to content

feat: group discounts #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 9, 2024
Merged

feat: group discounts #214

merged 8 commits into from
May 9, 2024

Conversation

field123
Copy link
Collaborator

@field123 field123 commented May 9, 2024

Describe your changes

  • grouping discounts from cart and item level discounts into single accessor functions
  • removing rxjs and adding simple native observable pattern impl

Issue ticket number and link

n/a

Checklist before requesting a review

Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
composable-frontend-algolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 1:25pm
composable-frontend-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 1:25pm
composable-frontend-simple ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 1:25pm

Copy link

changeset-bot bot commented May 9, 2024

🦋 Changeset detected

Latest commit: dab6c2f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@elasticpath/d2c-schematics Minor
@elasticpath/react-shopper-hooks Minor
composable-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented May 9, 2024

Deploy Preview for next-algolia-ep-cli ready!

Name Link
🔨 Latest commit dab6c2f
🔍 Latest deploy log https://app.netlify.com/sites/next-algolia-ep-cli/deploys/663ccdeaa89dd900080804d8
😎 Deploy Preview https://deploy-preview-214--next-algolia-ep-cli.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant