Skip to content

update appimage runtime #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Drsheppard01
Copy link

this will help alpine, nix, void and other users to use appimage

This pr also raises the question of the usefulness of other libraries such as gconf

@Drsheppard01 Drsheppard01 marked this pull request as ready for review December 31, 2024 09:39
@Samueru-sama
Copy link

Looks good, the only thing I'm not sure is why are the runtimes are also being added manually and not just changing the url to the type2-runtime repo?

@Drsheppard01
Copy link
Author

Looks good, the only thing I'm not sure is why are the runtimes are also being added manually and not just changing the url to the type2-runtime repo?

If I understand correctly, first the makefile is executed, then the reference is changed and a release of this binary is made, and after that electron-builder uses the binaries

@mmaietta
Copy link
Collaborator

FWIW, I'm attempting to redo the entire release process of electron-builder-binaries so that it fetches or compiles assets during CI/CD and publishes to combined releases with has
PR changes in my fork: mmaietta#2
Sample release: https://github.com/mmaietta/electron-builder-binaries/releases/tag/untagged-de49322cde58fe127c1a

As part of that, it'll be updating the appimage runtimes, so I think we can close this PR.
It does sound like runtime may no longer be needed though? I might just need to migrate to appimagetool?

Additional context:
I'm looking to remove as many pre-committed binaries from the repo as possible and instead do fresh compilations/downloads in ephemeral Github runners. Previously, all releases were handled by develar, assets compiled locally on a laptop, and then committed/released directly from the local computer. This is not a proper pipeline, nor considered secure by industry standards, so I'm attempting to standardize/secure the repo's pipeline BEFORE pushing a new release with artifacts with updated versions.

@Samueru-sama
Copy link

It does sound like runtime may no longer be needed though? I might just need to migrate to appimagetool?

Yes unless electron-builder has something to build offline, the runtimes don't need to be included.

@mmaietta
Copy link
Collaborator

Nifty! I'll add to my to-do list to investigate migrating to appimagetool then.

electron-builder can't do everything offline unless the electron-builder-binaries cache is already populated with all necessary tools; not sure if building offline is a hard requirement since it's highly unlikely electron-builder and all node_modules are committed directly to the project's repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants