-
Notifications
You must be signed in to change notification settings - Fork 64
update appimage runtime #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
update appimage runtime #57
Conversation
Looks good, the only thing I'm not sure is why are the runtimes are also being added manually and not just changing the url to the type2-runtime repo? |
If I understand correctly, first the makefile is executed, then the reference is changed and a release of this binary is made, and after that electron-builder uses the binaries |
FWIW, I'm attempting to redo the entire release process of electron-builder-binaries so that it fetches or compiles assets during CI/CD and publishes to combined releases with has As part of that, it'll be updating the appimage runtimes, so I think we can close this PR. Additional context: |
Yes unless electron-builder has something to build offline, the runtimes don't need to be included. |
Nifty! I'll add to my to-do list to investigate migrating to appimagetool then. electron-builder can't do everything offline unless the electron-builder-binaries cache is already populated with all necessary tools; not sure if building offline is a hard requirement since it's highly unlikely electron-builder and all node_modules are committed directly to the project's repo. |
this will help alpine, nix, void and other users to use appimage
This pr also raises the question of the usefulness of other libraries such as gconf