Skip to content

Flag to globally disable error tracking #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 8, 2024

Conversation

odarriba
Copy link
Contributor

@odarriba odarriba commented Sep 8, 2024

This change adds a new global flag named :enabled that allows to disable the error tracking on certain environments.

This behaviour can be done also with a custom ignorer using the changes that we will introduce in #79 , but I felt like this use case will be quite common in dev environments and having a fast way to just disable every error is useful.

Test have been added and documentation updated.

It is related to #81

@odarriba odarriba added the enhancement New feature or request label Sep 8, 2024
@odarriba odarriba requested a review from crbelaus September 8, 2024 07:55
@odarriba odarriba self-assigned this Sep 8, 2024
@odarriba
Copy link
Contributor Author

odarriba commented Sep 8, 2024

I felt like this would be useful, but some feedback will be appreciated @crbelaus as this can be done using ignorer functionality too. However, having to create a custom ignorer just for dev felt a bit too much for such a common use case.

Copy link
Contributor

@crbelaus crbelaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🚀

@crbelaus crbelaus merged commit 90f6edc into main Sep 8, 2024
3 checks passed
@crbelaus crbelaus deleted the globally-disable-error-tracker branch September 8, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants