Fix Oban.PerformError grouping #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odarriba
changed the title
crbelaus
approved these changes
Sep 11, 2024
Comment on lines
+78
to
+81
| stacktrace = | ||
| if stacktrace == [], | ||
| do: [{String.to_existing_atom("Elixir." <> job.worker), :perform, 2, []}], | ||
| else: stacktrace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves how we store data from
Oban.PerformErrorerrors.Those errors don't come from exceptions, as they are delivered via Telemetry when the worker ends up with an
:erroror an{:error, any()}tuple.As they are not exceptions, there is no stack trace, and they were been detected as the same error by our fingerprinting algo.
This changes introduces an fix that adds the worker module as the only stacktrace of the occurrence, so the error can populate the
source_functionattribute and different workers generate different error groupings.We cannot generate different error groups per different outputs of a worker. In that case, you should use
raise, that generates a full stack trace and works as expected.Closes #87