STM32 CAN: Make data()
return correct length slice
#4109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
data()
always returns an 8- or 64-byte slice, even though the actual CAN frame contains less data. The remaining bytes will be zero, so the user must check the frame DLC to see how many bytes were actually sent by the remote end. With this change the slice is the same length as was transmitted, with no extra bytes.Additionally removed the
ClassicData::MAX_DATA_LEN
constant because almost all instances were using a hardcoded8
anyway, and theFdData
only ever uses64
and doesn't have an equivalentMAX_DATA_LEN
. Happy to make everything useMAX_DATA_LEN
instead if that's preferred.Finally fixed a missing cfg gate on a defmt call that broke the build on G4 without defmt feature.