Skip to content

Throw an Exception that has a more descriptive message when trying to invoke getObjectNode for non-embulk-core DataSourceImpl #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Throw an Exception that has a more descriptive message when trying to invoke getObjectNode for non-embulk-core DataSourceImpl #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/org/embulk/util/config/Compat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,10 @@ private static Optional<String> callToJsonIfAvailable(final DataSource source) {
private static ObjectNode callGetObjectNodeAndRebuildIfAvailable(final DataSource source, final ObjectMapper mapper) {
final Class<? extends DataSource> coreDataSourceImplClass = source.getClass();
if (!coreDataSourceImplClass.getCanonicalName().equals("org.embulk.config.DataSourceImpl")) {
throw new ClassCastException("DataSource specified is not org.embulk.config.DataSourceImpl.");
throw new ClassCastException(
"DataSource specified is not org.embulk.config.DataSourceImpl. "
+ "The DataSource instance is unexpected to implement getObjectNode(). "
+ "DataSource class: " + source.getClass());
}
final Method getObjectNode = getGetObjectNodeMethod(coreDataSourceImplClass);
if (getObjectNode == null) {
Expand Down